feat(common): Release v2.0.3 (#203)

Co-authored-by: JJGadgets <git@jjgadgets.tech>
Co-authored-by: bjw-s-bot[bot] <87358111+bjw-s-bot[bot]@users.noreply.github.com>

charts/library/common/Chart.yaml

@@ -3,7 +3,7 @@ apiVersion: v2
 name: common
 description: Function library for Helm charts
 type: library
-version: 2.0.2
+version: 2.0.3
 kubeVersion: ">=1.22.0-0"
 keywords:
   - common
@@ -16,7 +16,4 @@ annotations:
   artifacthub.io/changes: |-
     - kind: fixed
       description: |-
-        ServiceAccount could not be referenced without creating
-    - kind: fixed
-      description: |-
-        Controllers without a type did not default to Deployment
+        Volumes did not render correctly across multiple controllers

charts/library/common/README.md

@@ -1,6 +1,6 @@
 # common
 
-![Version: 2.0.2](https://img.shields.io/badge/Version-2.0.2-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square)
+![Version: 2.0.3](https://img.shields.io/badge/Version-2.0.3-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square)
 
 Function library for Helm charts
 
@@ -27,7 +27,7 @@ Include this chart as a dependency in your `Chart.yaml` e.g.
 # Chart.yaml
 dependencies:
   - name: common
-    version: 2.0.2
+    version: 2.0.3
     repository: https://bjw-s.github.io/helm-charts/
 ```
 
@@ -61,7 +61,7 @@ The following table contains an overview of available values and their descripti
 | controllers.main.containers.main.image.pullPolicy | string | `nil` | image pull policy |
 | controllers.main.containers.main.image.repository | string | `nil` | image repository |
 | controllers.main.containers.main.image.tag | string | `nil` | image tag |
-| controllers.main.containers.main.lifecycle | object | `{}` | Configure the lifecycle for the container |
+| controllers.main.containers.main.lifecycle | object | `{}` | [[ref](https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/)] |
 | controllers.main.containers.main.nameOverride | string | `nil` | Override the container name |
 | controllers.main.containers.main.order | int | 99 | Override the default container order Containers get sorted alphanumerically by the `<order>-<identifier>` combination. |
 | controllers.main.containers.main.probes | object | See below | [[ref]](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/) |

charts/library/common/templates/lib/pod/fields/_volumes.tpl

@@ -18,10 +18,17 @@ Returns the value for volumes
     {{- end -}}
 
     {{- if $persistenceEnabled -}}
+      {{- $hasglobalMounts := not (empty $persistenceValues.globalMounts) -}}
+      {{- $globalMounts := dig "globalMounts" list $persistenceValues -}}
+
+      {{- $hasAdvancedMounts := not (empty $persistenceValues.advancedMounts) -}}
       {{- $advancedMounts := dig "advancedMounts" $controllerObject.identifier list $persistenceValues -}}
-      {{- if $advancedMounts -}}
-        {{- $_ := set $persistenceItemsToProcess $identifier $persistenceValues -}}
-      {{- else -}}
+
+      {{ if or
+        ($hasglobalMounts)
+        (and ($hasAdvancedMounts) (not (empty $advancedMounts)))
+        (and (not $hasglobalMounts) (not $hasAdvancedMounts))
+      -}}
         {{- $_ := set $persistenceItemsToProcess $identifier $persistenceValues -}}
       {{- end -}}
     {{- end -}}

charts/library/common/values.yaml

@@ -304,7 +304,8 @@ controllers:
         # -- Configure the Security Context for the container
         securityContext: {}
 
-        # -- Configure the lifecycle for the container
+        # -- Configure the lifecycle event hooks for the container
+        # -- [[ref](https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/)]
         lifecycle: {}
 
         # -- Configure the path at which the file to which the containers termination message will be written.