feat(common): Release version 1.2.1 (#95)

* fix(common): Clean leftover `secret` behavior under `envFrom`

* fix(common) wrong indentation in _cronjob.tpl (#99)

* fixed wrong indentation, cronjob + configmaps throws an error otherwise

* feat: Update code-server image tag to 4.9.1

* Allow setting `ttlSecondsAfterFinished` for CronJobs

Co-authored-by: loeken <loeken@internetz.me>

charts/library/common/Chart.yaml

@@ -3,7 +3,7 @@ apiVersion: v2
 name: common
 description: Function library for Helm charts
 type: library
-version: 1.2.0
+version: 1.2.1
 kubeVersion: ">=1.22.0-0"
 keywords:
   - common
@@ -15,12 +15,13 @@ maintainers:
 annotations:
   artifacthub.io/changes: |-
     - kind: fixed
-      description: Fixed sectionName not being optional for gateway routes
+      description: Fixed indentation in cronjob component to allow podAnnotations
     - kind: fixed
-      description: Fixed primary gateway route having incorrect name
-    - kind: fixed
-      description: Fixed invalid persistence type message
+      description: Cleaned leftover `secret` behavior under `envFrom`.
+      links:
+        - name: GitHub Issue
+          url: https://github.com/bjw-s/helm-charts/issues/94
+    - kind: changed
+      description: Updated code-server image tag to 4.9.1
     - kind: added
-      description: Added cronjob as controller.type
-    - kind: added
-      description: Allow setting container restartPolicy
+      description: Allow setting `ttlSecondsAfterFinished` for CronJobs

charts/library/common/README.md

@@ -1,6 +1,6 @@
 # common
 
-![Version: 1.2.0](https://img.shields.io/badge/Version-1.2.0-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square)
+![Version: 1.2.1](https://img.shields.io/badge/Version-1.2.1-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square)
 
 Function library for Helm charts
 
@@ -29,7 +29,7 @@ Include this chart as a dependency in your `Chart.yaml` e.g.
 # Chart.yaml
 dependencies:
 - name: common
-  version: 1.2.0
+  version: 1.2.1
   repository: https://bjw-s.github.io/helm-charts/
 ```
 

charts/library/common/templates/classes/_cronjob.tpl

@@ -27,11 +27,14 @@ spec:
   failedJobsHistoryLimit: {{ .Values.controller.cronjob.failedJobsHistory }}
   jobTemplate:
     spec:
+      {{- with .Values.controller.cronjob.ttlSecondsAfterFinished }}
+      ttlSecondsAfterFinished: {{ . }}
+      {{- end }}
       template:
         metadata:
           {{- with include ("bjw-s.common.lib.metadata.podAnnotations") . }}
           annotations:
-            {{- . | nindent 8 }}
+            {{- . | nindent 10 }}
           {{- end }}
           labels:
             {{- include "bjw-s.common.lib.metadata.selectorLabels" . | nindent 12 }}

charts/library/common/templates/lib/controller/_mainContainer.tpl

@@ -38,15 +38,9 @@
   env:
     {{- get (fromYaml (include "bjw-s.common.lib.container.envVars" $)) "env" | toYaml | nindent 4 -}}
   {{- end }}
-  {{- if or .Values.envFrom .Values.secret }}
+  {{- with .Values.envFrom }}
   envFrom:
-    {{- with .Values.envFrom }}
-      {{- toYaml . | nindent 4 }}
-    {{- end }}
-    {{- if .Values.secret }}
-    - secretRef:
-        name: {{ include "bjw-s.common.lib.chart.names.fullname" . }}
-    {{- end }}
+    {{- toYaml . | nindent 4 }}
   {{- end }}
   ports:
   {{- include "bjw-s.common.lib.container.ports" . | trim | nindent 4 }}

charts/library/common/values.yaml

@@ -52,6 +52,8 @@ controller:
     successfulJobsHistory: 1
     # -- The number of failed Jobs to keep
     failedJobsHistory: 1
+    # --  If this field is set, ttlSecondsAfterFinished after the Job finishes, it is eligible to be automatically deleted.
+    ttlSecondsAfterFinished:
 
 image:
   # -- image repository
@@ -709,7 +711,7 @@ addons:
       # -- Specify the code-server image
       repository: ghcr.io/coder/code-server
       # -- Specify the code-server image tag
-      tag: 4.8.3
+      tag: 4.9.1
       # -- Specify the code-server image pull policy
       pullPolicy: IfNotPresent