feat(common): Release version 1.3.1

charts/library/common/Chart.yaml

@@ -3,7 +3,7 @@ apiVersion: v2
 name: common
 description: Function library for Helm charts
 type: library
-version: 1.3.0
+version: 1.3.1
 kubeVersion: ">=1.22.0-0"
 keywords:
   - common
@@ -15,9 +15,4 @@ maintainers:
 annotations:
   artifacthub.io/changes: |-
     - kind: fixed
-      description: Don't render ports/probes when not required
-      links:
-        - name: GitHub Issue
-          url: https://github.com/bjw-s/helm-charts/issues/111
-    - kind: changed
-      description: Renamed `additionalContainers` to `sidecars`. The former will however still continue to work for the time being.
+      description: Probes were rendered incorrectly when primary service port was a string.

charts/library/common/README.md

@@ -1,6 +1,6 @@
 # common
 
-![Version: 1.3.0](https://img.shields.io/badge/Version-1.3.0-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square)
+![Version: 1.3.1](https://img.shields.io/badge/Version-1.3.1-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square)
 
 Function library for Helm charts
 
@@ -29,7 +29,7 @@ Include this chart as a dependency in your `Chart.yaml` e.g.
 # Chart.yaml
 dependencies:
 - name: common
-  version: 1.3.0
+  version: 1.3.1
   repository: https://bjw-s.github.io/helm-charts/
 ```
 

charts/library/common/templates/lib/chart/_notes.tpl

@@ -46,11 +46,11 @@ Default NOTES.txt content.
      NOTE: It may take a few minutes for the LoadBalancer IP to be available.
            You can watch the status of by running 'kubectl get svc -w {{ include "bjw-s.common.lib.chart.names.fullname" . }}'
   export SERVICE_IP=$(kubectl get svc --namespace {{ .Release.Namespace }} {{ include "bjw-s.common.lib.chart.names.fullname" . }} -o jsonpath='{.status.loadBalancer.ingress[0].ip}')
-  echo {{ $prefix }}://$SERVICE_IP:{{ $primaryPort.port }}
+  echo {{ $prefix }}://$SERVICE_IP:{{ $primaryPort.port | toString | atoi }}
 {{- else if contains "ClusterIP" $primaryService.type }}
   export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app.kubernetes.io/name={{ include "bjw-s.common.lib.chart.names.name" . }},app.kubernetes.io/instance={{ .Release.Name }}" -o jsonpath="{.items[0].metadata.name}")
   echo "Visit {{ $prefix }}://127.0.0.1:8080 to use your application"
-  kubectl port-forward $POD_NAME 8080:{{ $primaryPort.port }}
+  kubectl port-forward $POD_NAME 8080:{{ $primaryPort.port | toString | atoi }}
 {{- end }}
 {{- end }}
 {{- end -}}

charts/library/common/templates/lib/container/_probes.tpl

@@ -51,7 +51,7 @@ Probes selection logic.
           {{- else if $primaryPort.targetPort }}
             {{- $_ := set (index $probeDefinition $probeHeader) "port" $primaryPort.targetPort -}}
           {{- else }}
-            {{- $_ := set (index $probeDefinition $probeHeader) "port" $primaryPort.port -}}
+            {{- $_ := set (index $probeDefinition $probeHeader) "port" ($primaryPort.port | toString | atoi ) -}}
           {{- end }}
 
           {{- $probeOutput = $probeDefinition | toYaml | trim -}}