feat(common): Release common-3.0.4 (#294)

2025-07-03 16:37:04 +02:00 · 2024-03-15 09:33:07 +01:00 · 2024-03-15 09:33:07 +01:00 · 23164367ab
commit 23164367ab
parent 9541ab44fe
89 changed files with 427 additions and 216 deletions
--- a/charts/library/common-test/tests/_values/controllers_main_default_container.yaml
+++ b/charts/library/common-test/tests/_values/controllers_main_default_container.yaml
@ -0,0 +1,9 @@
+---
+controllers:
+  main:
+    containers:
+      main:
+        image:
+          repository: ghcr.io/mendhak/http-https-echo
+          tag: 31
+          pullPolicy: IfNotPresent
--- a/charts/library/common-test/tests/chart/validations_test.yaml
+++ b/charts/library/common-test/tests/chart/validations_test.yaml
@ -3,6 +3,8 @@
 suite: Chart validations
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: advancedMounts invalid controller reference should fail
    set:
--- a/charts/library/common-test/tests/configmap/metadata_test.yaml
+++ b/charts/library/common-test/tests/configmap/metadata_test.yaml
@ -3,6 +3,8 @@
 suite: configmap metadata
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default metadata should pass
    set:
--- a/charts/library/common-test/tests/configmap/names_test.yaml
+++ b/charts/library/common-test/tests/configmap/names_test.yaml
@ -3,6 +3,8 @@
 suite: configMap names
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/configmap/pod_metadata_test.yaml
+++ b/charts/library/common-test/tests/configmap/pod_metadata_test.yaml
@ -3,6 +3,8 @@
 suite: configmap Pod metadata
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default metadata should pass
    set:
--- a/charts/library/common-test/tests/container/args_test.yaml
+++ b/charts/library/common-test/tests/container/args_test.yaml
@ -3,6 +3,8 @@
 suite: container args override
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/container/command_test.yaml
+++ b/charts/library/common-test/tests/container/command_test.yaml
@ -3,6 +3,8 @@
 suite: container command override
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/container/env_test.yaml
+++ b/charts/library/common-test/tests/container/env_test.yaml
@ -3,6 +3,8 @@
 suite: container env values
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/container/envfrom_test.yaml
+++ b/charts/library/common-test/tests/container/envfrom_test.yaml
@ -3,6 +3,8 @@
 suite: container envFrom values
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/container/field_restartpolicy_test.yaml
+++ b/charts/library/common-test/tests/container/field_restartpolicy_test.yaml
@ -3,6 +3,8 @@
 suite: container restartPolicy
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/container/image_test.yaml
+++ b/charts/library/common-test/tests/container/image_test.yaml
@ -3,6 +3,8 @@
 suite: container image tag
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: string tag should pass
    set:
--- a/charts/library/common-test/tests/container/name_test.yaml
+++ b/charts/library/common-test/tests/container/name_test.yaml
@ -3,6 +3,8 @@
 suite: container name
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: with explicit name should pass
    set:
--- a/charts/library/common-test/tests/container/ports_test.yaml
+++ b/charts/library/common-test/tests/container/ports_test.yaml
@ -3,6 +3,8 @@
 suite: container ports
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/container/probes_test.yaml
+++ b/charts/library/common-test/tests/container/probes_test.yaml
@ -3,7 +3,8 @@
 suite: container probes
 templates:
  - common.yaml
-
+values:
+  - ../_values/controllers_main_default_container.yaml
 set:
  controllers.main.containers.main.probes.liveness.enabled: true
  controllers.main.containers.main.probes.readiness.enabled: true
--- a/charts/library/common-test/tests/container/validations_test.yaml
+++ b/charts/library/common-test/tests/container/validations_test.yaml
@ -3,6 +3,8 @@
 suite: Container validations
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: image repository is required
    set:
--- a/charts/library/common-test/tests/container/volumemounts_test.yaml
+++ b/charts/library/common-test/tests/container/volumemounts_test.yaml
@ -3,6 +3,8 @@
 suite: container volumeMounts
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: no persistence should pass
    asserts:
--- a/charts/library/common-test/tests/container/workingdir_test.yaml
+++ b/charts/library/common-test/tests/container/workingdir_test.yaml
@ -3,6 +3,8 @@
 suite: container workingDir override
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/controller/cronjob_test.yaml
+++ b/charts/library/common-test/tests/controller/cronjob_test.yaml
@ -3,6 +3,8 @@
 suite: cronjob configuration
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default cronjob configuration should pass
    set:
--- a/charts/library/common-test/tests/controller/job_test.yaml
+++ b/charts/library/common-test/tests/controller/job_test.yaml
@ -3,6 +3,8 @@
 suite: job configuration
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default job configuration should pass
    set:
--- a/charts/library/common-test/tests/controller/metadata_cronjob_test.yaml
+++ b/charts/library/common-test/tests/controller/metadata_cronjob_test.yaml
@ -3,7 +3,8 @@
 suite: controller metadata cronjob
 templates:
  - common.yaml
-
+values:
+  - ../_values/controllers_main_default_container.yaml
 set:
  controllers.main.cronjob.schedule: "*/20 * * * *"

--- a/charts/library/common-test/tests/controller/metadata_daemonset_test.yaml
+++ b/charts/library/common-test/tests/controller/metadata_daemonset_test.yaml
@ -3,6 +3,8 @@
 suite: controller metadata daemonset
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default metadata should pass
    set:
--- a/charts/library/common-test/tests/controller/metadata_deployment_test.yaml
+++ b/charts/library/common-test/tests/controller/metadata_deployment_test.yaml
@ -3,6 +3,8 @@
 suite: controller metadata deployment
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default metadata should pass
    set:
--- a/charts/library/common-test/tests/controller/metadata_job_test.yaml
+++ b/charts/library/common-test/tests/controller/metadata_job_test.yaml
@ -3,6 +3,8 @@
 suite: controller metadata job
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default metadata should pass
    set:
--- a/charts/library/common-test/tests/controller/metadata_statefulset_test.yaml
+++ b/charts/library/common-test/tests/controller/metadata_statefulset_test.yaml
@ -3,6 +3,8 @@
 suite: controller metadata statefulset
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default metadata should pass
    set:
--- a/charts/library/common-test/tests/controller/type_test.yaml
+++ b/charts/library/common-test/tests/controller/type_test.yaml
@ -3,6 +3,8 @@
 suite: controller types
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/ingress/metadata_test.yaml
+++ b/charts/library/common-test/tests/ingress/metadata_test.yaml
@ -3,10 +3,9 @@
 suite: ingress metadata
 templates:
  - common.yaml
-
 values:
  - ../_values/ingress_main_default_hosts.yaml
-
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default metadata should pass
    asserts:
--- a/charts/library/common-test/tests/ingress/presence_test.yaml
+++ b/charts/library/common-test/tests/ingress/presence_test.yaml
@ -3,6 +3,9 @@
 suite: ingress presence
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/ingress/service_reference_test.yaml
+++ b/charts/library/common-test/tests/ingress/service_reference_test.yaml
@ -3,10 +3,9 @@
 suite: ingress service reference
 templates:
  - common.yaml
-
 values:
  - ../_values/ingress_main_default_hosts.yaml
-
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    set:
--- a/charts/library/common-test/tests/ingress/tls_test.yaml
+++ b/charts/library/common-test/tests/ingress/tls_test.yaml
@ -3,10 +3,9 @@
 suite: ingress tls
 templates:
  - common.yaml
-
 values:
  - ../_values/ingress_main_default_hosts.yaml
-
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/ingress/values_test.yaml
+++ b/charts/library/common-test/tests/ingress/values_test.yaml
@ -3,11 +3,10 @@
 suite: ingress values
 templates:
  - common.yaml
-
 values:
  - ../_values/ingress_main_default_hosts.yaml
  - ../_values/service_main_default.yaml
-
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/misc/nameoverride_test.yaml
+++ b/charts/library/common-test/tests/misc/nameoverride_test.yaml
@ -3,6 +3,8 @@
 suite: nameOverride tests
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default name is set to release name
    asserts:
--- a/charts/library/common-test/tests/networkpolicy/metadata_test.yaml
+++ b/charts/library/common-test/tests/networkpolicy/metadata_test.yaml
@ -12,6 +12,8 @@ set:

 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default metadata should pass
    asserts:
--- a/charts/library/common-test/tests/networkpolicy/names_test.yaml
+++ b/charts/library/common-test/tests/networkpolicy/names_test.yaml
@ -3,6 +3,8 @@
 suite: networkPolicy names
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    set:
--- a/charts/library/common-test/tests/networkpolicy/validations_test.yaml
+++ b/charts/library/common-test/tests/networkpolicy/validations_test.yaml
@ -3,6 +3,8 @@
 suite: NetworkPolicy validations
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: networkpolicy requires either controller reference or podSelector
    set:
--- a/charts/library/common-test/tests/networkpolicy/values_test.yaml
+++ b/charts/library/common-test/tests/networkpolicy/values_test.yaml
@ -3,7 +3,8 @@
 suite: NetworkPolicy values
 templates:
  - common.yaml
-
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: main networkpolicy is disabled by default
    asserts:
--- a/charts/library/common-test/tests/persistence/claimnames_test.yaml
+++ b/charts/library/common-test/tests/persistence/claimnames_test.yaml
@ -3,6 +3,8 @@
 suite: persistence claimnames
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    set:
--- a/charts/library/common-test/tests/persistence/configmap_test.yaml
+++ b/charts/library/common-test/tests/persistence/configmap_test.yaml
@ -3,6 +3,8 @@
 suite: persistence configmap
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: configmap persistence type should pass
    set:
--- a/charts/library/common-test/tests/persistence/custom.yaml
+++ b/charts/library/common-test/tests/persistence/custom.yaml
@ -3,6 +3,8 @@
 suite: persistence custom
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: custom persistence type should pass
    set:
--- a/charts/library/common-test/tests/persistence/emptydir_test.yaml
+++ b/charts/library/common-test/tests/persistence/emptydir_test.yaml
@ -3,6 +3,8 @@
 suite: persistence emptydir
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default emptyDir should pass
    set:
--- a/charts/library/common-test/tests/persistence/hostpath_test.yaml
+++ b/charts/library/common-test/tests/persistence/hostpath_test.yaml
@ -3,6 +3,8 @@
 suite: persistence hostpath
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: hostPath should pass
    set:
--- a/charts/library/common-test/tests/persistence/nfs_test.yaml
+++ b/charts/library/common-test/tests/persistence/nfs_test.yaml
@ -3,6 +3,8 @@
 suite: persistence nfs
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: nfs persistence type should pass
    set:
--- a/charts/library/common-test/tests/persistence/secret_test.yaml
+++ b/charts/library/common-test/tests/persistence/secret_test.yaml
@ -3,6 +3,8 @@
 suite: persistence secret
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: secret persistence type should pass
    set:
--- a/charts/library/common-test/tests/persistence/volumeclaimtemplates_test.yaml
+++ b/charts/library/common-test/tests/persistence/volumeclaimtemplates_test.yaml
@ -3,6 +3,8 @@
 suite: persistence volumeclaimtemplates
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    set:
--- a/charts/library/common-test/tests/persistence/volumes_test.yaml
+++ b/charts/library/common-test/tests/persistence/volumes_test.yaml
@ -3,6 +3,8 @@
 suite: persistence volumes
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: no persistence should pass
    asserts:
--- a/charts/library/common-test/tests/pod/additional_containers_test.yaml
+++ b/charts/library/common-test/tests/pod/additional_containers_test.yaml
@ -3,6 +3,8 @@
 suite: pod with multiple containers
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: with explicit name should pass
    set:
--- a/charts/library/common-test/tests/pod/container_order_test.yaml
+++ b/charts/library/common-test/tests/pod/container_order_test.yaml
@ -3,6 +3,8 @@
 suite: pod sidecar containers
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: with default order
    set:
--- a/charts/library/common-test/tests/pod/field_affinity_test.yaml
+++ b/charts/library/common-test/tests/pod/field_affinity_test.yaml
@ -3,6 +3,8 @@
 suite: pod affinity
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_dnsConfig_test.yaml
+++ b/charts/library/common-test/tests/pod/field_dnsConfig_test.yaml
@ -3,6 +3,8 @@
 suite: pod dnsConfig
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_dnsPolicy_test.yaml
+++ b/charts/library/common-test/tests/pod/field_dnsPolicy_test.yaml
@ -3,6 +3,8 @@
 suite: pod dnsPolicy
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_enableServiceLinks_test.yaml
+++ b/charts/library/common-test/tests/pod/field_enableServiceLinks_test.yaml
@ -3,6 +3,8 @@
 suite: pod enableServiceLinks
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_hostAliases_test.yaml
+++ b/charts/library/common-test/tests/pod/field_hostAliases_test.yaml
@ -3,6 +3,8 @@
 suite: pod hostAliases
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_hostIPC_test.yaml
+++ b/charts/library/common-test/tests/pod/field_hostIPC_test.yaml
@ -3,6 +3,8 @@
 suite: pod security
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_hostNetwork_test.yaml
+++ b/charts/library/common-test/tests/pod/field_hostNetwork_test.yaml
@ -3,6 +3,8 @@
 suite: pod hostNetwork
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_hostPID_test.yaml
+++ b/charts/library/common-test/tests/pod/field_hostPID_test.yaml
@ -3,6 +3,8 @@
 suite: pod security
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_imagePullSecrets_test.yaml
+++ b/charts/library/common-test/tests/pod/field_imagePullSecrets_test.yaml
@ -3,6 +3,8 @@
 suite: pod imagePullSecrets
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_nodeSelector_test.yaml
+++ b/charts/library/common-test/tests/pod/field_nodeSelector_test.yaml
@ -3,6 +3,8 @@
 suite: pod nodeSelector
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_replicas_test.yaml
+++ b/charts/library/common-test/tests/pod/field_replicas_test.yaml
@ -3,6 +3,8 @@
 suite: pod replicas
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_securityContext_test.yaml
+++ b/charts/library/common-test/tests/pod/field_securityContext_test.yaml
@ -3,6 +3,8 @@
 suite: pod securityContext
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_serviceAccount_test.yaml
+++ b/charts/library/common-test/tests/pod/field_serviceAccount_test.yaml
@ -3,6 +3,8 @@
 suite: pod serviceAccount
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_tolerations_test.yaml
+++ b/charts/library/common-test/tests/pod/field_tolerations_test.yaml
@ -3,6 +3,8 @@
 suite: pod tolerations
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/field_topologySpreadConstraints_test.yaml
+++ b/charts/library/common-test/tests/pod/field_topologySpreadConstraints_test.yaml
@ -3,6 +3,8 @@
 suite: pod topologySpreadConstraints
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/pod/initcontainers_test.yaml
+++ b/charts/library/common-test/tests/pod/initcontainers_test.yaml
@ -3,6 +3,8 @@
 suite: pod initContainers
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: with custom env vars dict should pass
    set:
--- a/charts/library/common-test/tests/pvc/datasource_test.yaml
+++ b/charts/library/common-test/tests/pvc/datasource_test.yaml
@ -3,7 +3,8 @@
 suite: pvc datasource
 templates:
  - common.yaml
-
+values:
+  - ../_values/controllers_main_default_container.yaml
 set:
  persistence.config:
    accessMode: ReadWriteOnce
--- a/charts/library/common-test/tests/pvc/metadata_test.yaml
+++ b/charts/library/common-test/tests/pvc/metadata_test.yaml
@ -3,7 +3,8 @@
 suite: pvc metadata
 templates:
  - common.yaml
-
+values:
+  - ../_values/controllers_main_default_container.yaml
 set:
  persistence.config:
    accessMode: ReadWriteOnce
--- a/charts/library/common-test/tests/pvc/names_test.yaml
+++ b/charts/library/common-test/tests/pvc/names_test.yaml
@ -3,7 +3,8 @@
 suite: pvc names
 templates:
  - common.yaml
-
+values:
+  - ../_values/controllers_main_default_container.yaml
 set:
  persistence.config:
    accessMode: ReadWriteOnce
--- a/charts/library/common-test/tests/pvc/storageclass_test.yaml
+++ b/charts/library/common-test/tests/pvc/storageclass_test.yaml
@ -3,7 +3,8 @@
 suite: pvc storageclass
 templates:
  - common.yaml
-
+values:
+  - ../_values/controllers_main_default_container.yaml
 set:
  persistence.config:
    accessMode: ReadWriteOnce
--- a/charts/library/common-test/tests/pvc/values_test.yaml
+++ b/charts/library/common-test/tests/pvc/values_test.yaml
@ -3,6 +3,8 @@
 suite: pvc values
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default enabled should pass
    set:
--- a/charts/library/common-test/tests/route/metadata_test.yaml
+++ b/charts/library/common-test/tests/route/metadata_test.yaml
@ -3,6 +3,8 @@
 suite: route metadata
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default metadata should pass
    set:
--- a/charts/library/common-test/tests/route/presence_test.yaml
+++ b/charts/library/common-test/tests/route/presence_test.yaml
@ -3,6 +3,8 @@
 suite: route presence
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/route/service_reference_test.yaml
+++ b/charts/library/common-test/tests/route/service_reference_test.yaml
@ -3,6 +3,8 @@
 suite: route service reference
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    set:
--- a/charts/library/common-test/tests/route/values_test.yaml
+++ b/charts/library/common-test/tests/route/values_test.yaml
@ -3,6 +3,8 @@
 suite: route values
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: setting gateway should pass
    set:
--- a/charts/library/common-test/tests/secret/metadata_test.yaml
+++ b/charts/library/common-test/tests/secret/metadata_test.yaml
@ -3,6 +3,8 @@
 suite: secret metadata
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default metadata should pass
    set:
--- a/charts/library/common-test/tests/secret/names_test.yaml
+++ b/charts/library/common-test/tests/secret/names_test.yaml
@ -3,6 +3,8 @@
 suite: secret names
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    asserts:
--- a/charts/library/common-test/tests/secret/pod_metadata_test.yaml
+++ b/charts/library/common-test/tests/secret/pod_metadata_test.yaml
@ -3,6 +3,8 @@
 suite: secret Pod metadata
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default metadata should pass
    set:
--- a/charts/library/common-test/tests/service/metadata_test.yaml
+++ b/charts/library/common-test/tests/service/metadata_test.yaml
@ -3,6 +3,8 @@
 suite: service metadata
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default metadata should pass
    values:
--- a/charts/library/common-test/tests/service/names_test.yaml
+++ b/charts/library/common-test/tests/service/names_test.yaml
@ -3,6 +3,8 @@
 suite: service names
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    values:
--- a/charts/library/common-test/tests/service/port_protocols_test.yaml
+++ b/charts/library/common-test/tests/service/port_protocols_test.yaml
@ -3,6 +3,8 @@
 suite: service protocols
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    values:
--- a/charts/library/common-test/tests/service/ports_test.yaml
+++ b/charts/library/common-test/tests/service/ports_test.yaml
@ -3,6 +3,8 @@
 suite: service ports
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: default should pass
    values:
--- a/charts/library/common-test/tests/service/validations_test.yaml
+++ b/charts/library/common-test/tests/service/validations_test.yaml
@ -3,6 +3,8 @@
 suite: Service validations
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: invalid controller reference should fail
    set:
--- a/charts/library/common-test/tests/service/values_test.yaml
+++ b/charts/library/common-test/tests/service/values_test.yaml
@ -3,6 +3,8 @@
 suite: service values
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: ports and services are enabled by default
    set:
--- a/charts/library/common-test/tests/serviceAccount/serviceaccount_test.yaml
+++ b/charts/library/common-test/tests/serviceAccount/serviceaccount_test.yaml
@ -3,6 +3,8 @@
 suite: serviceAccount values
 templates:
  - common.yaml
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: a serviceAccount is not created by default
    asserts:
--- a/charts/library/common-test/tests/serviceMonitor/servicemonitor_test.yaml
+++ b/charts/library/common-test/tests/serviceMonitor/servicemonitor_test.yaml
@ -3,7 +3,8 @@
 suite: serviceMonitor values
 templates:
  - common.yaml
-
+values:
+  - ../_values/controllers_main_default_container.yaml
 tests:
  - it: a serviceMonitor is not created by default
    asserts:
--- a/charts/library/common-test/values.yaml
+++ b/charts/library/common-test/values.yaml
@ -1,9 +0,0 @@
---
-controllers:
-  main:
-    containers:
-      main:
-        image:
-          repository: ghcr.io/mendhak/http-https-echo
-          tag: 31
-          pullPolicy: IfNotPresent
--- a/charts/library/common/Chart.yaml
+++ b/charts/library/common/Chart.yaml
@ -3,7 +3,7 @@ apiVersion: v2
 name: common
 description: Function library for Helm charts
 type: library
-version: 3.0.3
+version: 3.0.4
 kubeVersion: ">=1.22.0-0"
 keywords:
  - common
@ -16,7 +16,4 @@ annotations:
  artifacthub.io/changes: |-
    - kind: fixed
      description: |-
-        Fixed probes intermittently choosing the wrong service
-    - kind: fixed
-      description: |-
-        Prevent potential incorrect controller references
+        Improved fix for preventing potential incorrect controller references
--- a/charts/library/common/README.md
+++ b/charts/library/common/README.md
@ -1,6 +1,6 @@
 # common

-![Version: 3.0.3](https://img.shields.io/badge/Version-3.0.3-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square)
+![Version: 3.0.4](https://img.shields.io/badge/Version-3.0.4-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square)

 Function library for Helm charts

@ -27,7 +27,7 @@ Include this chart as a dependency in your `Chart.yaml` e.g.
 # Chart.yaml
 dependencies:
  - name: common
-    version: 3.0.3
+    version: 3.0.4
    repository: https://bjw-s.github.io/helm-charts/
 ```

--- a/charts/library/common/schemas/containers.json
+++ b/charts/library/common/schemas/containers.json
@ -36,14 +36,13 @@
        ]
      },
      "env": {
-        "anyOf": [
+        "oneOf": [
          {
            "type": "array",
            "items": {
              "anyOf": [
-                {"$ref": "#/envValueWithName"},
-                {"$ref": "#/envValueFromWithName"},
-                {"$ref": "#/envImplicitValueFromWithName"}
+                {"$ref": "envVars.json#/envVarListItem"},
+                {"$ref": "envVars.json#/valueFromListItem"}
              ]
            }
          },
@ -51,10 +50,9 @@
            "type": "object",
            "additionalProperties": {
              "anyOf": [
-                {"type": ["string", "number", "boolean", "null"]},
-                {"$ref": "#/envValue"},
-                {"$ref": "#/envValueFrom"},
-                {"$ref": "#/envImplicitValueFrom"}
+                {"$ref": "envVars.json#/envVarValue"},
+                {"$ref": "envVars.json#/envVarItem"},
+                {"$ref": "envVars.json#/valueFromItem"}
              ]
            }
          }
@ -164,180 +162,6 @@
    }
  },

-  "envValueWithName": {
-    "type": "object",
-    "additionalProperties": false,
-    "properties": {
-      "name": {
-        "type": "string"
-      },
-      "value": {
-        "type": ["string", "number", "boolean", "null"]
-      }
-    },
-    "required": ["name", "value"]
-  },
-
-  "envValue": {
-    "type": "object",
-    "additionalProperties": false,
-    "properties": {
-      "value": {
-        "type": ["string", "number", "boolean", "null"]
-      },
-      "dependsOn": {"$ref": "#/envDependsOn"}
-    },
-    "required": ["value"]
-  },
-
-  "envValueFromWithName": {
-    "type": "object",
-    "additionalProperties": false,
-    "properties": {
-      "name": {
-        "type": "string"
-      },
-      "valueFrom": {
-        "oneOf": [
-          {"$ref": "#/envValueFrom.fieldRef"},
-          {"$ref": "#/envValueFrom.secretKeyRef"}
-        ]
-      },
-      "dependsOn": {"$ref": "#/envDependsOn"}
-    },
-    "required": ["name", "valueFrom"]
-  },
-
-  "envValueFrom": {
-    "type": "object",
-    "additionalProperties": false,
-    "properties": {
-      "valueFrom": {
-        "oneOf": [
-          {"$ref": "#/envValueFrom.fieldRef"},
-          {"$ref": "#/envValueFrom.secretKeyRef"}
-        ]
-      },
-      "dependsOn": {"$ref": "#/envDependsOn"}
-    },
-    "required": ["valueFrom"]
-  },
-
-  "envImplicitValueFromWithName": {
-    "type": "object",
-    "additionalProperties": false,
-    "properties": {
-      "name": {
-        "type": "string"
-      },
-      "fieldRef": {"$ref": "#/envValueFrom.fieldPath"},
-      "secretKeyRef": {"$ref": "#/envValueFrom.secretKeyRef"},
-      "configMapKeyRef": {"$ref": "#/envValueFrom.configMapKeyRef"}
-    },
-    "required": ["name"],
-    "dependencies": {
-      "fieldRef": {
-        "allOf": [
-          {"not": {"required": ["secretKeyRef"]}},
-          {"not": {"required": ["configMapKeyRef"]}}
-        ]
-      },
-      "secretKeyRef": {
-        "allOf": [
-          {"not": {"required": ["fieldRef"]}},
-          {"not": {"required": ["configMapKeyRef"]}}
-        ]
-      },
-      "configMapKeyRef": {
-        "allOf": [
-          {"not": {"required": ["secretKeyRef"]}},
-          {"not": {"required": ["configMapKeyRef"]}}
-        ]
-      }
-    }
-  },
-
-  "envImplicitValueFrom": {
-    "type": "object",
-    "oneOf": [
-      {"$ref": "#/envValueFrom.fieldRef"},
-      {"$ref": "#/envValueFrom.secretKeyRef"},
-      {"$ref": "#/envValueFrom.configMapKeyRef"}
-    ]
-  },
-
-  "envDependsOn": {
-    "oneOf": [
-      {"type": "string"},
-      {"type": "array", "items": {"type": "string"}}
-    ]
-  },
-
-  "envValueFrom.secretKeyRef": {
-    "type": "object",
-    "additionalProperties": false,
-    "properties": {
-      "secretKeyRef": {
-        "type": "object",
-        "properties": {
-          "name": {
-            "type": "string"
-          },
-          "key": {
-            "type": "string"
-          }
-        },
-        "required": ["name", "key"]
-      }
-    },
-    "required": ["secretKeyRef"]
-  },
-
-  "envValueFrom.configMapKeyRef": {
-    "type": "object",
-    "additionalProperties": false,
-    "properties": {
-      "configMapKeyRef": {
-        "type": "object",
-        "properties": {
-          "name": {
-            "type": "string"
-          },
-          "key": {
-            "type": "string"
-          }
-        },
-        "required": ["name", "key"]
-      }
-    },
-    "required": ["configMapKeyRef"]
-  },
-
-  "envValueFrom.fieldRef": {
-    "type": "object",
-    "additionalProperties": false,
-    "properties": {
-      "fieldRef": {
-        "$ref": "#/envValueFrom.fieldPath"
-      }
-    },
-    "required": ["fieldRef"]
-  },
-
-  "envValueFrom.fieldPath": {
-    "type": "object",
-    "additionalProperties": false,
-    "properties": {
-      "apiVersion": {
-        "type": "string"
-      },
-      "fieldPath": {
-        "type": "string"
-      }
-    },
-    "required": ["fieldPath"]
-  },
-
  "probe": {
    "additionalProperties": false,
    "properties": {
--- a/charts/library/common/schemas/envVars.json
+++ b/charts/library/common/schemas/envVars.json
@ -0,0 +1,245 @@
+{
+  "envVarValue": {
+    "type": ["string", "number", "boolean", "null"]
+  },
+
+  "envVarListItem": {
+    "type": "object",
+    "additionalProperties": false,
+    "properties": {
+      "name": {"type": "string"},
+      "value": {"$ref": "#/envVarValue"}
+    },
+    "required": ["name", "value"]
+  },
+
+  "envVarItem": {
+    "type": "object",
+    "additionalProperties": false,
+    "properties": {
+      "value": {"$ref": "#/envVarValue"},
+      "dependsOn": {"$ref": "#/envVarDependsOn"}
+    },
+    "required": ["value"]
+  },
+
+  "valueFromListItem": {
+    "oneOf": [
+      {"$ref": "#/valueFromListItemExplicit"},
+      {"$ref": "#/valueFromListItemImplicit"}
+    ]
+  },
+
+  "valueFromListItemExplicit": {
+    "type": "object",
+    "additionalProperties": false,
+    "properties": {
+      "name": {"type": "string"},
+      "valueFrom": {"$ref": "#/valueFromOptions"}
+    },
+    "required": ["name", "valueFrom"]
+  },
+
+  "valueFromListItemImplicit": {
+    "type": "object",
+    "additionalProperties": false,
+    "properties": {
+      "name": {"type": "string"},
+      "fieldRef": {"$ref": "#/fieldRefSelector"},
+      "resourceFieldRef": {"$ref": "#/resourceFieldRefSelector"},
+      "secretKeyRef": {"$ref": "#/objectKeySelector"},
+      "configMapKeyRef": {"$ref": "#/objectKeySelector"}
+    },
+    "required": ["name"],
+    "dependencies": {
+      "fieldRef": {
+        "allOf": [
+          {"not": {"required": ["resourceFieldRef"]}},
+          {"not": {"required": ["secretKeyRef"]}},
+          {"not": {"required": ["configMapKeyRef"]}}
+        ]
+      },
+      "resourceFieldRef": {
+        "allOf": [
+          {"not": {"required": ["fieldRef"]}},
+          {"not": {"required": ["secretKeyRef"]}},
+          {"not": {"required": ["configMapKeyRef"]}}
+        ]
+      },
+      "secretKeyRef": {
+        "allOf": [
+          {"not": {"required": ["fieldRef"]}},
+          {"not": {"required": ["resourceFieldRef"]}},
+          {"not": {"required": ["configMapKeyRef"]}}
+        ]
+      },
+      "configMapKeyRef": {
+        "allOf": [
+          {"not": {"required": ["fieldRef"]}},
+          {"not": {"required": ["resourceFieldRef"]}},
+          {"not": {"required": ["secretKeyRef"]}}
+        ]
+      }
+    }
+  },
+
+  "valueFromItem": {
+    "oneOf": [
+      {"$ref": "#/valueFromItemExplicit"},
+      {"$ref": "#/valueFromItemImplicit"}
+    ]
+  },
+
+  "valueFromItemExplicit": {
+    "type": "object",
+    "additionalProperties": false,
+    "properties": {
+      "valueFrom": {"$ref": "#/valueFromOptions"},
+      "dependsOn": {"$ref": "#/envVarDependsOn"}
+    },
+    "required": ["valueFrom"]
+  },
+
+  "valueFromItemImplicit": {
+    "type": "object",
+    "additionalProperties": false,
+    "properties": {
+      "fieldRef": {"$ref": "#/fieldRefSelector"},
+      "resourceFieldRef": {"$ref": "#/resourceFieldRefSelector"},
+      "secretKeyRef": {"$ref": "#/objectKeySelector"},
+      "configMapKeyRef": {"$ref": "#/objectKeySelector"},
+      "dependsOn": {"$ref": "#/envVarDependsOn"}
+    },
+    "dependencies": {
+      "fieldRef": {
+        "allOf": [
+          {"not": {"required": ["resourceFieldRef"]}},
+          {"not": {"required": ["secretKeyRef"]}},
+          {"not": {"required": ["configMapKeyRef"]}}
+        ]
+      },
+      "resourceFieldRef": {
+        "allOf": [
+          {"not": {"required": ["fieldRef"]}},
+          {"not": {"required": ["secretKeyRef"]}},
+          {"not": {"required": ["configMapKeyRef"]}}
+        ]
+      },
+      "secretKeyRef": {
+        "allOf": [
+          {"not": {"required": ["fieldRef"]}},
+          {"not": {"required": ["resourceFieldRef"]}},
+          {"not": {"required": ["configMapKeyRef"]}}
+        ]
+      },
+      "configMapKeyRef": {
+        "allOf": [
+          {"not": {"required": ["fieldRef"]}},
+          {"not": {"required": ["resourceFieldRef"]}},
+          {"not": {"required": ["secretKeyRef"]}}
+        ]
+      }
+    }
+  },
+
+  "valueFromOptions": {
+    "type": "object",
+    "oneOf": [
+      {"$ref": "#/fieldRef"},
+      {"$ref": "#/resourceFieldRef"},
+      {"$ref": "#/secretKeyRef"},
+      {"$ref": "#/configMapKeyRef"}
+    ]
+  },
+
+  "secretKeyRef": {
+    "type": "object",
+    "additionalProperties": false,
+    "properties": {
+      "secretKeyRef": {"$ref": "#/objectKeySelector"}
+    },
+    "required": ["secretKeyRef"]
+  },
+
+  "configMapKeyRef": {
+    "type": "object",
+    "additionalProperties": false,
+    "properties": {
+      "configMapKeyRef": {"$ref": "#/objectKeySelector"}
+    },
+    "required": ["configMapKeyRef"]
+  },
+
+  "fieldRef": {
+    "type": "object",
+    "additionalProperties": false,
+    "properties": {
+      "fieldRef": {"$ref": "#/fieldRefSelector"}
+    },
+    "required": ["fieldRef"]
+  },
+
+  "fieldRefSelector": {
+    "type": "object",
+    "additionalProperties": false,
+    "properties": {
+      "apiVersion": {
+        "type": "string"
+      },
+      "fieldPath": {
+        "type": "string"
+      }
+    },
+    "required": ["fieldPath"]
+  },
+
+  "resourceFieldRef": {
+    "type": "object",
+    "additionalProperties": false,
+    "properties": {
+      "resourceFieldRef": {"$ref": "#/resourceFieldRefSelector"}
+    },
+    "required": ["resourceFieldRef"]
+  },
+
+  "resourceFieldRefSelector": {
+    "type": "object",
+    "additionalProperties": false,
+    "properties": {
+      "containerName": {
+        "type": "string"
+      },
+      "divisor": {
+        "oneOf": [{"type": "string"}, {"type": "number"}]
+      },
+      "resource": {
+        "type": "string"
+      }
+    },
+    "required": ["resource"]
+  },
+
+  "envVarDependsOn": {
+    "oneOf": [
+      {"type": "string"},
+      {
+        "type": "array",
+        "items": {"type": "string"}
+      }
+    ]
+  },
+
+  "objectKeySelector": {
+    "type": "object",
+    "additionalProperties": false,
+    "properties": {
+      "name": {
+        "type": "string"
+      },
+      "key": {
+        "type": "string"
+      }
+    },
+    "required": ["name", "key"]
+  }
+}
--- a/charts/library/common/templates/lib/service/_primary_port.tpl
+++ b/charts/library/common/templates/lib/service/_primary_port.tpl
@ -18,8 +18,10 @@ Return the primary port for a given Service object.
  {{- /* Return the first port if none has been explicitly marked as primary */ -}}
  {{- if not $result -}}
    {{- $firstPortKey := keys $enabledPorts | first -}}
+    {{- if $firstPortKey -}}
      {{- $result = get $enabledPorts $firstPortKey -}}
    {{- end -}}
+  {{- end -}}

  {{- $result | toYaml -}}
 {{- end -}}
--- a/charts/library/common/values.schema.json
+++ b/charts/library/common/values.schema.json
@ -1,6 +1,6 @@
 {
  "$schema": "http://json-schema.org/draft-07/schema",
-  "$id": "https://raw.githubusercontent.com/bjw-s/helm-charts/common-3.0.3/charts/library/common/values.schema.json",
+  "$id": "https://raw.githubusercontent.com/bjw-s/helm-charts/common-3.0.4/charts/library/common/values.schema.json",

  "type": "object",
  "properties": {