fix: mDNS lookup

fbx/api_version.go

@@ -124,54 +124,51 @@ func (f *FreeboxAPIVersion) newFreeboxAPIVersionMDNS(*FreeboxHttpClient) error {
 
 	// mDNS lookup
 	go func() {
-		defer close(entries)
+		for entry := range entries {
-		if err := mdns.Lookup(mdnsService, entries); err != nil {
+			deviceName := entry.Name
-			log.Error.Println("mDNS lookup failed:", err)
+			idx := strings.Index(deviceName, ".")
+			if idx >= 0 {
+				deviceName = deviceName[0:idx]
+			}
+			deviceName = strings.ReplaceAll(deviceName, "\\", "")
+
+			*f = FreeboxAPIVersion{
+				DeviceName: deviceName,
+			}
+			for i := range entry.InfoFields {
+				kv := strings.SplitN(entry.InfoFields[i], "=", 2)
+				if len(kv) != 2 {
+					break
+				}
+				switch kv[0] {
+				case "api_domain":
+					f.APIDomain = kv[1]
+				case "uid":
+					f.UID = kv[1]
+				case "https_available":
+					f.HTTPSAvailable = (kv[1] == "1")
+				case "https_port":
+					port, _ := strconv.ParseUint(kv[1], 10, 16)
+					f.HTTPSPort = uint16(port)
+				case "api_version":
+					f.APIVersion = kv[1]
+				case "api_base_url":
+					f.APIBaseURL = kv[1]
+				case "device_type":
+					f.DeviceType = kv[1]
+				default:
+				}
+			}
 		}
-		log.Debug.Println("End of mDNS lookup")
 	}()
 
-	for entry := range entries {
+	if err := mdns.Lookup(mdnsService, entries); err != nil {
-		deviceName := entry.Name
+		log.Error.Println("mDNS lookup failed:", err)
-		idx := strings.Index(deviceName, ".")
+		return err
-		if idx >= 0 {
-			deviceName = deviceName[0:idx]
-		}
-		deviceName = strings.ReplaceAll(deviceName, "\\", "")
-
-		*f = FreeboxAPIVersion{
-			DeviceName: deviceName,
-		}
-		for i := range entry.InfoFields {
-			kv := strings.SplitN(entry.InfoFields[i], "=", 2)
-			if len(kv) != 2 {
-				break
-			}
-			switch kv[0] {
-			case "api_domain":
-				f.APIDomain = kv[1]
-			case "uid":
-				f.UID = kv[1]
-			case "https_available":
-				f.HTTPSAvailable = (kv[1] == "1")
-			case "https_port":
-				port, _ := strconv.ParseUint(kv[1], 10, 16)
-				f.HTTPSPort = uint16(port)
-			case "api_version":
-				f.APIVersion = kv[1]
-			case "api_base_url":
-				f.APIBaseURL = kv[1]
-			case "device_type":
-				f.DeviceType = kv[1]
-			default:
-			}
-		}
-		if f.IsValid() {
-			return nil
-		}
 	}
-
+	log.Debug.Println("End of mDNS lookup")
-	return errors.New("MDNS timeout")
+	close(entries)
+	return nil
 }
 
 func (f *FreeboxAPIVersion) setQueryApiVersion(forceApiVersion int) error {