If cached value for NITZ is used, the time at which it was
received needs to be cached too.
Test: Basic telephony sanity
Bug: 72283604
Change-Id: I8f443171c4583e3eab9be7973d7714ae6c7ab6af
The payload of a SAP request could be freed twice in certain scenarios.
Also, add null-checks to prevent dereferencing of null pointers.
Bug: 64729356
Test: Manually run the fuzz tests and ensure that there is no crash in
rild
Change-Id: Ib7ae269fa5297d6acea267337b220b8858c82bae
Re-add constant for function pointer table to
RIL_RadioFunctions. Const was accidentally removed
during a warnings cleanup.
Bug: 64231560
Test: compilation
Change-Id: I93675980c51d9162f624495d12fe3c97f1da8031
clang is the default compiler since Android nougat
Change-Id: I0555fa8067352fd43b47aabe80be1224597da17e
Signed-off-by: Lennart Wieboldt <lennart.1997@gmx.de>
* Our platform requires 0x02000000U (USAGE_PRIVATE_UNCACHED) for
camera, video, and various other functionality
Change-Id: Ie5a8a46fef1c0f28ebd2cd3b3d29cc19763bc2a3
* These features have long been enabled by default in the audio HAL,
but things changed since the unification of the audio policy HAL.
Set all of them here, also to make it easily clear what is used.
Change-Id: I5bdb5fda3b9d5add5b9bac1f6980607761fbd692
* This is required to enable our legacy HAL1 camera recording
following OMX hardening in Ief2d2d4d0445074c0ecdc723b1b25997a7631389
Change-Id: Ide8dad10bf72fbd1acefec2f8ef4a90b0e3c0a4b
* Set FIFO values to 0 for all sensors to disable batching.
* Only change the delay for batch calls.
Change-Id: I8e8384e63a24122e02f3c6c7e09311561c180c17
* Rename hals.conf -> _hals.conf so legitimate
MultiHAL won't attempt to load our HALs.
* Rename multihal -> multihal-samsung8974 so soong
doesn't complain about duplicate package names.
* Remove USE_SENSOR_MULTI_HAL flag requirement so
we can actually build it.
* Use TARGET_BOARD_PLATFORM variable in package
name because it's a common tree.
Change-Id: Ifa8c20747e3f0bf9bae8b42dd4c499cf6d770e27
Upstream change I732234a22328a1bfcb603bb020547f543b6fd766 makes
RIL_UNSOL_DC_RT_INFO_CHANGED's responseFunction() NULL, without
protecting against it in RIL_onUnsolicitedResponse(), thus crash-
ing at least hammerhead's RIL stack upon mobile data connection.
https://android-review.googlesource.com/#/c/platform/hardware/ril/+/345950/
Change-Id: I6567019cb6daf6492a29e04cc9872e69b2ba456d
Signed-off-by: D. Andrei Măceș <Andrei.Maces@alumni.nd.edu>
(cherry picked from commit e73eafff8695ab28201acbc03a362d5b177047aa)
Testing response times to time.android.com from around the globe reveals
in ms:-
Europe <30
Middle East <68
North America <150
Johannesburg 183
Buenos Aires 220
Tokyo 226
Sydney 276
Hong Kong 285
Brisbane 295
Mumbai 349
Beijing 4691
Shanghai 4906
Russia n/a
Whilst time.android.com is NOT used for GPS NTP, North American time servers
are, by specifying north-america.pool.ntp.org as default in the framework,
to align with pixel devices. I am assuming similar response times to these
servers from around the world.
Great for North America and it appears Europe but it does not address the
global issue. Also, the pool.ntp.org project forbids both hardware and
software vendors from using these default zone names.
http://www.pool.ntp.org/en/vendors.html
It makes sense, therefore, to leverage the ntp.org's existing 'android' vendor
name to make the default ntp server for GPS purposes:
1.android.pool.ntp.org this will return a random but accurate NTP server in
close geopraphic proximity to the device.
Testing on my own build in the UK seems to improve hot and cold TTFF
considerably.
Change-Id: I144af45757efa35b32daf034eece6e046d2bde79
* These should be set appropriately by carrier, and should already be
at the correct values by default in packages/apps/CarrierConfig
Change-Id: I433b110570c2b79b15076dadf58777e0289e347a
* All of the libsec-ril*.so libraries reference these symbols, but
Google finally dropped the non-inlined versions from libcutils with
Android 8.0. This could be handled with shims in numerous device
trees, but shim semantics and implementation aren't exactly stable
and we can handle it more cleanly here in one place.
* See LineageOS/android_system_core@103e8f560
Change-Id: I787372b739f3ace0d9cbbc33e4bffafa6876665e
* Up until now, vendor build properties were added into /system/build.prop
when property split isn't enabled. However, Google realised that
either /vendor/build.prop or /system/vendor/build.prop can always exist,
and decided to clean up code and always install vendor build props
into $(TARGET_OUT_VENDOR)/build.prop.
* For this reason, the unified devices that used to override build props
such as build fingerprint, will need to override the matching vendor
build props.
Change-Id: Iacdd8eb67543daff5a46b92dbaf17cd094ce462b
* This is necessary for the built-in music player to play files off
of fuse (NTFS, in our case, for the most part) volumes
Change-Id: Ib6fffb5c2b5c8c514979a7aabce949d82902b2d1
* XTRA_SERVERs are important, right? Like to get the almanac data
necessary for aGPS. Without the XTRA download, the chip needs to
collect sufficient navigation messages from the birds to compute
where they are in order to make sense of the ranging signals.
* Well, it seems that O doesn't like reading these entries from the
gps.conf file.
When in gps.conf:
GpsXtraDownloader: No XTRA servers were specified in the GPS configuration
When in overlay:
<that noise doesn't exist>
* This seems to, finally, return GPS fix performance to what we had
in N.
Change-Id: I70679835ec5dea053c5aa3750acee628906d6390
* While msm8974 is not 64 bit, certain users of this libril will be
* A previous revision of this libril had 16 bytes of padding in this
struct for 64-bit platforms (due to word size and struct alignment),
but a change by me to use a long instead of a pointer and an int
broke this padding for 64-bit platforms because a long is still
just 8 bytes on 64-bit platforms, where 16 bytes is necessary
* Use two pointers as padding instead to make 64-bit great again
Change-Id: If599bdb625f7a45e083f5b30df512d12810be79b
This reverts commit 24d70a1aec.
* The new HIDL power HAL seems to be appropriately riced^Wfixed for
8974 now.
Change-Id: I629ab2314dec4698a0d4d45d77cdc48bf92a4d74