lineage/android_device_samsung_msm8974-common
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

msm8974-common: gps: Fix for buffer overrun crash at copying nmea string

Browse Source 
Add zero clearing of allocated nmea buffer to ensure
the nmea string is null terminated.

Change-Id: Ie36010a7d3eca16dabb3067ae891a94e4b63b10c
CRs-Fixed: 2041933
This commit is contained in:
Katz Yamada 2017-05-07 11:22:28 -07:00 committed by Kevin F. Haggerty
parent 2efdd808f9
commit 3138fafbcd
No known key found for this signature in database
GPG Key ID: 6D95512933112729
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gps/loc_api/libloc_api_50001/loc_eng.cpp
View File

@ -891,9 +891,9 @@ inline void LocEngReportStatus::log() const {
// case LOC_ENG_MSG_REPORT_NMEA: // case LOC_ENG_MSG_REPORT_NMEA:
LocEngReportNmea::LocEngReportNmea(void* locEng, LocEngReportNmea::LocEngReportNmea(void* locEng,
const char* data, int len) : const char* data, int len) :
LocMsg(), mLocEng(locEng), mNmea(new char[len]), mLen(len) LocMsg(), mLocEng(locEng), mNmea(new char[len+1]), mLen(len)
{ {
memcpy((void*)mNmea, (void*)data, len); strlcpy(mNmea, data, len+1);
locallog(); locallog();
} }
void LocEngReportNmea::proc() const { void LocEngReportNmea::proc() const {